[Chromedriver] Add method to match capabilities to be more compliant with w3c spec

Desktop / Chromium - kereliuk [chromium.org] - 12 July 2017 15:43 EDT

[Chromedriver] Add method to match capabilities to be more compliant with w3c spec.

w3c spec: https://w3c.github.io/webdriver/webdriver-spec.html#processing-capabilities

Currently matches with browserName and adds setWindowRect when creating capabilities. Other capabilities are difficult to get (such as browserVersion which is hard to get without starting the browser) and are ignored for now.

BUG=chromedriver:1740

Review-Url: https://codereview.chromium.org/2968173002 Cr-Commit-Position: refs/heads/master@{#486062}

2855231 [Chromedriver] Add method to match capabilities to be more compliant with w3c spec.
chrome/test/chromedriver/session_commands.cc | 28 +++++++++++++++++++---
chrome/test/chromedriver/session_commands.h | 2 ++
.../test/chromedriver/session_commands_unittest.cc | 12 ++++++++++
3 files changed, 39 insertions(+), 3 deletions(-)

Upstream: git.chromium.org


  • Share