[Chromedriver] Support long command line on Android

Desktop / Chromium - johnchen [chromium.org] - 14 July 2017 14:21 EDT

On Android devices, ChromeDriver used to use shell "echo" command to send Chrome command line to the device. Adb limits the length of the command line that can be sent this way, ranging from less than 1000 characters to about 4000 characters, depending on the Adb
version.

To allow longer command line to be used, ChromeDriver now uses Adb file transfer protocol to send the command line file to the device. This is the same underlying protocol used by "adb push" command.

BUG=727979

Review-Url: https://codereview.chromium.org/2972913002 Cr-Commit-Position: refs/heads/master@{#486815}

4e04992 [Chromedriver] Support long command line on Android
chrome/test/chromedriver/chrome/adb_impl.cc | 35 +++---
chrome/test/chromedriver/net/adb_client_socket.cc | 137 ++++++++++++++++++++++
chrome/test/chromedriver/net/adb_client_socket.h | 8 +-
3 files changed, 165 insertions(+), 15 deletions(-)

Upstream: git.chromium.org


  • Share