[CrOS Tether] Add Tether networks to the Wireless and NonVirtual NetworkTypePatterns

Desktop / Chromium - khorimoto [chromium.org] - 15 June 2017 18:24 EDT

Combined with https://codereview.chromium.org/2937783002/, this CL has the effect of updating the system tray icon (to animating cellular connection bars) when connecting to a Tether network.

Note: As part of this CL, AutoConnectHandler was updated to call into NetworkConnectionHandler instead of to Shill directly when initiating a disconnection. The reason for this change is that Tether networks are now considered to be Wireless, this code path could now be run for Tether networks. Disconnecting from Tether networks must occur through NetworkConnectionHandler instead of through Shill, since Tether networks are not recognized by Shill.

BUG=672263

Review-Url: https://codereview.chromium.org/2936983002 Cr-Commit-Position: refs/heads/master@{#479866}

a5bf048 [CrOS Tether] Add Tether networks to the Wireless and NonVirtual NetworkTypePatterns.
ash/system/network/network_icon.cc | 6 +--
chromeos/network/auto_connect_handler.cc | 29 ++++++++++--
chromeos/network/auto_connect_handler_unittest.cc | 57 +++++++++++++++++++++--
chromeos/network/network_state.cc | 4 ++
chromeos/network/network_type_pattern.cc | 4 +-
chromeos/network/network_type_pattern_unittest.cc | 12 ++---
6 files changed, 91 insertions(+), 21 deletions(-)

Upstream: git.chromium.org


  • Share