[JS] Implemented navigator.credentials.create()

Desktop / Chromium - Tomasz Garbus [chromium.org] - 12 September 2017 07:53 EDT

This CL contains navigator.credentials.create(options), as described here: https://w3c.github.io/webappsec-credential-management/#dom-credentialscontainer-create

7 out of 15 tests are passing on iOS here: https://w3c-test.org/credential-management/credentialscontainer-create-basics.https.html

- 3 tests are failing because they test PublicKeyCredential which is not meant to be implemented in this file.

- 1 test is failing because of bug crbug.com/762011. Instead of TypeError, Promise is rejected with NotSupportedError

- 4 tests are failing because on iOS DOMException.name is not a string, so testharness.js fails this line: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/testharness.js?type=cs&q=testharness+promise_test&l=1279 Promise is still rejected with DOMException of correct type (DOMException.NOT_SUPPORTED_ERR)

Bug: 435046 Change-Id: Ica5a55425f1071398fe2e2b5d936234bcffa5750 Reviewed-on: https://chromium-review.googlesource.com/650355

8539662 [JS] Implemented navigator.credentials.create()
.../browser/web/resources/credential_manager.js | 34 ++++++++++++++++++----
1 file changed, 28 insertions(+), 6 deletions(-)

Upstream: git.chromium.org


  • Share