[Offline pages]: Add ability to attribute download button clicks to apps

Desktop / Chromium - Cathy Li [chromium.org] - 9 August 2017 11:34 EDT

Bug: 734753 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia3cf2158295dc7243d4659938673a25ce44594d3 Reviewed-on: https://chromium-review.googlesource.com/560799 Commit-Queue: Cathy Li

7187388 [Offline pages]: Add ability to attribute download button clicks to apps
.../chrome/browser/download/DownloadUtils.java | 7 +-
.../browser/offlinepages/OfflinePageBridge.java | 32 ++++--
.../browser/offlinepages/OfflinePageItem.java | 10 +-
.../browser/offlinepages/OfflinePageOrigin.java | 109 +++++++++++++++++++++
.../downloads/OfflinePageDownloadBridge.java | 9 +-
.../evaluation/OfflinePageEvaluationBridge.java | 11 +--
chrome/android/java_sources.gni | 2 +
.../offlinepages/OfflinePageBridgeTest.java | 43 ++++++++
.../browser/ntp/cards/SuggestionsSectionTest.java | 2 +-
.../offlinepages/OfflinePageBridgeUnitTest.java | 3 +-
.../offlinepages/OfflinePageOriginUnitTest.java | 27 +++++
.../downloads/offline_page_download_bridge.cc | 18 ++--
.../downloads/offline_page_download_bridge.h | 8 +-
.../evaluation/offline_page_evaluation_bridge.cc | 3 +-
.../offline_pages/android/offline_page_bridge.cc | 12 ++-
.../offline_pages/android/offline_page_bridge.h | 3 +-
.../offline_pages/offline_page_tab_helper.cc | 14 ++-
.../offline_pages/offline_page_tab_helper.h | 14 +--
chrome/browser/offline_pages/offline_page_utils.cc | 14 ++-
chrome/browser/offline_pages/offline_page_utils.h | 6 ++
chrome/browser/offline_pages/recent_tab_helper.cc | 21 ++--
chrome/browser/offline_pages/recent_tab_helper.h | 3 +-
.../offline_pages/recent_tab_helper_unittest.cc | 55 ++++++++---
.../resources/offline_pages/offline_internals.html | 21 ++++
.../resources/offline_pages/offline_internals.js | 61 ++++--------
.../offline_internals_browser_proxy.js | 6 +-
.../offline_internals_ui_message_handler.cc | 2 +
27 files changed, 397 insertions(+), 119 deletions(-)

Upstream: git.chromium.org


  • Share