[Password Manager] Show omnibox icon and anchored prompt once users start typing password

Desktop / Chromium - kolos [chromium.org] - 10 August 2017 05:00 EDT

If the password to be save is a generated by Chrome password, the confirmation bubble will be shown (the bubble that a user sees when she submits a form with generated password).

If the password is not a generated one, a save or update bubble will be shown.

BUG=725883

Review-Url: https://codereview.chromium.org/2915763003 Cr-Commit-Position: refs/heads/master@{#493337}

7cf7408 [Password Manager] Show omnibox icon and anchored prompt once users start typing password
.../chrome_password_manager_client.cc | 26 +++
.../chrome_password_manager_client.h | 7 +-
.../credential_manager_browsertest.cc | 22 +-
.../password_manager_browsertest.cc | 232 +++++++++------------
.../password_manager_interactive_uitest.cc | 22 +-
.../password_manager/password_manager_test_base.cc | 177 +++++++++++++---
.../password_manager/password_manager_test_base.h | 36 +++-
.../ui/passwords/manage_passwords_ui_controller.cc | 26 +++
.../ui/passwords/manage_passwords_ui_controller.h | 5 +
.../manage_passwords_ui_controller_unittest.cc | 83 ++++++++
.../ui/passwords/passwords_client_ui_delegate.h | 12 ++
.../fake_content_password_manager_driver.cc | 9 +
.../fake_content_password_manager_driver.h | 14 +-
.../password_autofill_agent_browsertest.cc | 76 +++++++
.../autofill/content/common/autofill_driver.mojom | 8 +
.../content/renderer/password_autofill_agent.cc | 16 +-
...derer_save_password_progress_logger_unittest.cc | 5 +
.../password_manager/content/browser/bad_message.h | 1 +
.../browser/content_password_manager_driver.cc | 13 ++
.../browser/content_password_manager_driver.h | 2 +
.../core/browser/password_manager.cc | 48 ++++-
.../core/browser/password_manager.h | 9 +
.../core/browser/password_manager_client.h | 13 +-
.../core/browser/password_manager_driver.h | 8 +
.../core/browser/password_manager_unittest.cc | 118 ++++++++++-
.../core/browser/stub_password_manager_client.cc | 7 +
.../core/browser/stub_password_manager_client.h | 5 +
.../passwords/ios_chrome_password_manager_client.h | 5 +
.../ios_chrome_password_manager_client.mm | 11 +
tools/metrics/histograms/enums.xml | 5 +
30 files changed, 815 insertions(+), 206 deletions(-)

Upstream: git.chromium.org


  • Share