[PresentationAPI] Remove message handling logic from PresentationDispatcher

Desktop / Chromium - Derek Cheng [chromium.org] - 13 July 2017 19:17 EDT

- Remove message queue / message handling logic from PresentationDispatcher.- Move Send{Text,Binary}Message methods from WebPresentationClient to WebPresentationConnectionProxy.
- Remove unused DidReceive*Message methods from WebPresentationController.

Note that there is behavior change; previously the sending of a message is blocked on the other side having processed the previous message successfully. This pattern was previously used for control flow purposes and is no longer deemed useful.

Bug: 684116 Change-Id: I3589c4c047e7b5c16ff1a92a0d5e72bbf932023f Reviewed-on: https://chromium-review.googlesource.com/563766 Commit-Queue: Derek Cheng

2fd16c4 [PresentationAPI] Remove message handling logic from PresentationDispatcher.
.../presentation/presentation_connection_proxy.cc | 47 ++++++-
.../presentation/presentation_connection_proxy.h | 10 +-
.../presentation_connection_proxy_unittest.cc | 17 +--
.../presentation/presentation_dispatcher.cc | 156 ---------------------
.../presentation/presentation_dispatcher.h | 71 +---------
.../presentation_dispatcher_unittest.cc | 76 +---------
.../presentation/PresentationConnection.cpp | 22 ++-
.../presentation/PresentationController.cpp | 19 ---
.../modules/presentation/PresentationController.h | 5 -
.../modules/presentation/WebPresentationClient.h | 32 -----
.../presentation/WebPresentationConnectionProxy.h | 13 +-
.../presentation/WebPresentationController.h | 9 --
12 files changed, 70 insertions(+), 407 deletions(-)

Upstream: git.chromium.org


  • Share