[iOS] Add UITextInputAssistantItems on iPad for the toolbar

Desktop / Chromium - Jean-Fran├žois Geyelin [chromium.org] - 7 August 2017 06:35 EDT

With this CL, the "assistive views" (voice search, qr code search, ".com", "/", etc...) are presented on iPads using UITextInputAssistantItems. Using UITextInputAssistantItems instead of a Keyboard Accessory View (still used on iPhones) allows iOS to correctly split keyboards.

Bug: None. Change-Id: I175d0c3b6ae5207cb0e99405d81328a0df97bf6e Reviewed-on: https://chromium-review.googlesource.com/598230 Commit-Queue: Jean-Fran├žois Geyelin

f0ca23f [iOS] Add UITextInputAssistantItems on iPad for the toolbar.
.../browser/ui/toolbar/keyboard_assist/BUILD.gn | 6 ++
.../toolbar_assistive_keyboard_views.h | 16 ++---
.../toolbar_assistive_keyboard_views.mm | 72 +++++-----------------
.../toolbar_assistive_keyboard_views_utils.h | 16 +++++
.../toolbar_assistive_keyboard_views_utils.mm | 60 ++++++++++++++++++
.../toolbar_input_assistant_items.h | 21 +++++++
.../toolbar_input_assistant_items.mm | 49 +++++++++++++++
.../toolbar_keyboard_accessory_view.h | 6 +-
.../toolbar_keyboard_accessory_view.mm | 1 +
.../keyboard_assist/toolbar_ui_bar_button_item.h | 22 +++++++
.../keyboard_assist/toolbar_ui_bar_button_item.mm | 36 +++++++++++
11 files changed, 238 insertions(+), 67 deletions(-)

Upstream: git.chromium.org


  • Share