[iOS] Prepare for the support of InputAssistantItems on iPad

Desktop / Chromium - Jean-Fran├žois Geyelin [chromium.org] - 12 July 2017 12:25 EDT

This CL cleans the Keyboard Accessory View (KAV) situation for the web toolbar to support InputAssistantItems on iPad (1). In particular, this CL:
- Removes keyboard_accessory_view.*. Now only new_keyboard_accessory_view.* is used.- Removes HardwareKeyboardWatcher because it only works when there is a KAV (crbug.com/740898).- Removes |-locationBarChanged| because it would only be used to record MobileFirstTextInOmnibox (crbug.com/740611).- Removes the |_keyboardAccessoryView| ivar. It was used when the KAV was not laid out with auto layout and had multiple modes.

(1) https://docs.google.com/document/d/1pWfwHEeCNeWgkDjawJiDoEf93gkDV9usINcYDyXvwcY/edit#heading=h.sku52p315l4d

Bug: 738106, 708341, 740611 Change-Id: If6e509de3e6d57f0347b3e355b91af16bd055adb Reviewed-on: https://chromium-review.googlesource.com/567087

7774ffb [iOS] Prepare for the support of InputAssistantItems on iPad.
ios/chrome/browser/ui/keyboard/BUILD.gn | 5 -
.../ui/keyboard/hardware_keyboard_watcher.h | 31 ----
.../ui/keyboard/hardware_keyboard_watcher.mm | 96 ------------
.../keyboard/hardware_keyboard_watcher_unittest.mm | 122 ---------------
.../ui/omnibox/location_bar_controller_impl.mm | 1 -
ios/chrome/browser/ui/toolbar/BUILD.gn | 4 +-
.../browser/ui/toolbar/keyboard_accessory_view.h | 33 -----
.../browser/ui/toolbar/keyboard_accessory_view.mm | 165 ---------------------
...otocol.h => keyboard_accessory_view_delegate.h} | 25 +---
.../ui/toolbar/new_keyboard_accessory_view.h | 5 +-
.../ui/toolbar/new_keyboard_accessory_view.mm | 9 +-
.../browser/ui/toolbar/web_toolbar_controller.mm | 86 +++--------
.../browser/ui/omnibox/location_bar_mediator.mm | 5 -
.../browser/ui/omnibox/location_bar_delegate.h | 1 -
14 files changed, 29 insertions(+), 559 deletions(-)

Upstream: git.chromium.org


  • Share