[ios clean] Add height constraint to NTP header

Desktop / Chromium - gambard [chromium.org] - 10 August 2017 12:53 EDT

The height of the NTP header is different between clean and old chrome. Old Chrome has the toolbar embedded inside the header and its height must take it into account. Clean's toolbar is outside of the header.

Bug: 753391 Change-Id: Ie0471a4083daeb74ccea7ee3467477ee6f80ca70 Reviewed-on: https://chromium-review.googlesource.com/608107 Commit-Queue: Gauthier Ambard

79ae89d3 [ios clean] Add height constraint to NTP header
.../content_suggestions_coordinator.mm | 4 ++--
.../content_suggestions_header_view_controller.mm | 2 +-
ios/chrome/browser/ui/content_suggestions/BUILD.gn | 2 ++
.../content_suggestions_collection_utils.h | 18 +++++++++-------
.../content_suggestions_collection_utils.mm | 19 +++++++++--------
...ontent_suggestions_collection_utils_unittest.mm | 24 +++++++++++++++-------
ios/chrome/browser/ui/ntp/BUILD.gn | 6 ++++--
.../ui/ntp/google_landing_view_controller.mm | 10 ++++-----
ios/clean/chrome/browser/ui/ntp/BUILD.gn | 2 ++
.../browser/ui/ntp/ntp_home_header_mediator.mm | 4 ++--
.../ui/ntp/ntp_home_header_view_controller.mm | 2 +-
11 files changed, 58 insertions(+), 35 deletions(-)

Upstream: git.chromium.org


  • Share