[ios clean] Add overflow buttons for ToolsMenu

Desktop / Chromium - sczs [chromium.org] - 16 February 2017 14:53 EST

-ToolsMenu adds a StackView subclass (MenuOverflowControlsStack) as a first element when in compact widths.-ToolsMenu is dismissed everytime the ToolbarLayout changes (Rotation, iPad multitasking,etc.) this mimics current behavior.-MenuOverflowControlsStack currently uses ToolbarButtons as a placeholder, but this is not necessarily how it needs to be.-MenuOverflowControlsStack UI is not yet ready, this CL is more about the logic of adding/removing the Stack, and not the contents.

Screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgQmFzYXZsNkd2ZlU

BUG=682880

Review-Url: https://codereview.chromium.org/2693043002 Cr-Commit-Position: refs/heads/master@{#451065}

7f21fa5 [ios clean] Add overflow buttons for ToolsMenu.
ios/clean/chrome/browser/ui/toolbar/BUILD.gn | 23 ++++++++---
.../browser/ui/toolbar/toolbar_view_controller.mm | 6 +++
ios/clean/chrome/browser/ui/tools/BUILD.gn | 4 ++
.../ui/tools/menu_overflow_controls_stackview.h | 25 ++++++++++++
.../ui/tools/menu_overflow_controls_stackview.mm | 46 ++++++++++++++++++++++
.../browser/ui/tools/menu_view_controller.mm | 39 ++++++++++++++----
6 files changed, 129 insertions(+), 14 deletions(-)

Upstream: git.chromium.org


  • Share