[ios] Adds support for closeSettings via dispatcher

Desktop / Chromium - sczs [chromium.org] - 10 August 2017 11:57 EDT

This CL adds dispatcher support for both IDC_CLOSE_SETTINGS_AND_OPEN_URL and IDC_CLOSE_SETTINGS. It also uses the new dispatcher support in accounts_CVC in order to test that its working.

Since IDC_CLOSE_SETTINGS is used downstream, this CL doesn't remove any previous IDC_COMMAND functionality. This way downstream will not break. That will be done once downstream changes have landed.

Bug: 738881 Change-Id: Idc2bbac04ff41515fee0679e3730a5de516884d8 Reviewed-on: https://chromium-review.googlesource.com/609598

9e6e374 [ios] Adds support for closeSettings via dispatcher.
ios/chrome/app/main_controller.mm | 12 +++++++++--
.../browser/ui/commands/application_commands.h | 7 +++++++
.../settings/accounts_collection_view_controller.h | 10 +++++----
.../accounts_collection_view_controller.mm | 24 ++++++++++------------
.../ui/settings/settings_navigation_controller.mm | 7 ++++---
.../browser/user_feedback/user_feedback_provider.h | 6 ++++++
.../user_feedback/user_feedback_provider.mm | 6 ++++++
7 files changed, 50 insertions(+), 22 deletions(-)

Upstream: git.chromium.org


  • Share