[ios] Wraps PageInfo in a coordinator

Desktop / Chromium - Gregory Chatzinoff [chromium.org] - 8 September 2017 21:32 EDT

The new PageInfoLegacyCoordinator class manages all presentation and dismissal of the Page Info UI as a single entry point to the feature. All dependencies are managed by the protocols in requirements, and relevant commands are split out into a PageInfoCommands protocol.

Bug: none Change-Id: I6cecb8d6ac154e051dff6a8e5a3caf965ef53c0f Reviewed-on: https://chromium-review.googlesource.com/646953 Commit-Queue: Gregory Chatzinoff

df93d69 [ios] Wraps PageInfo in a coordinator.
WATCHLISTS | 2 +-
ios/chrome/browser/ui/BUILD.gn | 2 +
ios/chrome/browser/ui/browser_view_controller.h | 4 -
ios/chrome/browser/ui/browser_view_controller.mm | 109 ++++------------
ios/chrome/browser/ui/commands/BUILD.gn | 1 +
ios/chrome/browser/ui/commands/browser_commands.h | 13 +-
.../browser/ui/commands/page_info_commands.h | 26 ++++
ios/chrome/browser/ui/fullscreen_controller.mm | 1 +
ios/chrome/browser/ui/omnibox/BUILD.gn | 10 --
ios/chrome/browser/ui/overscroll_actions/BUILD.gn | 1 +
.../overscroll_actions_controller.mm | 1 +
ios/chrome/browser/ui/page_info/BUILD.gn | 56 ++++++++
.../ui/page_info/page_info_legacy_coordinator.h | 54 ++++++++
.../ui/page_info/page_info_legacy_coordinator.mm | 143 +++++++++++++++++++++
.../ui/{omnibox => page_info}/page_info_model.cc | 4 +-
.../ui/{omnibox => page_info}/page_info_model.h | 6 +-
.../page_info_model_observer.h | 6 +-
.../page_info_view_controller.h | 14 +-
.../page_info_view_controller.mm | 14 +-
.../browser/ui/page_info/requirements/BUILD.gn | 10 ++
.../requirements/page_info_presentation.h | 22 ++++
21 files changed, 371 insertions(+), 128 deletions(-)

Upstream: git.chromium.org


  • Share