[subresource_filter] Gate stronger popup blocking behind an experiment param

Desktop / Chromium - Charles Harrison [chromium.org] - 15 June 2017 14:33 EDT

The stronger popup blocker is very aggressive, and it would be wise to gate it behind a separate finch param, so we can selectively enable it under certain conditions (e.g. only after a phishing interstitial).

This CL disables it by default, and does not add it to any preset, though that may be subject to change in the near future.

Bug: 733330 Change-Id: Icf097d9e3a4863f2417a8804568285328af62bf2 Reviewed-on: https://chromium-review.googlesource.com/537033

794e35f [subresource_filter] Gate stronger popup blocking behind an experiment param
.../subresource_filter_browsertest.cc | 29 ++++++++++++++++++
.../content_subresource_filter_driver_factory.cc | 4 +++
.../content_subresource_filter_driver_factory.h | 1 +
.../content_subresource_filter_throttle_manager.cc | 8 ++++-
.../content_subresource_filter_throttle_manager.h | 1 +
.../core/browser/subresource_filter_features.cc | 8 +++++
.../core/browser/subresource_filter_features.h | 5 ++++
.../subresource_filter_features_unittest.cc | 34 ++++++++++++++++++++++
8 files changed, 89 insertions(+), 1 deletion(-)

Upstream: git.chromium.org


  • Share