🏡 Remove loading suggestions placeholder

Desktop / Chromium - Peter E Conn [chromium.org] - 12 October 2017 10:51 EDT

Remove the placeholder shown when suggestions are loading. Replace the associated ContentSuggestions.FetchPendingPlaceholder.VisibleDuration with ContentSuggestions.FetchPendingSpinner.VisibleDuration.

Bug: Implementation Review Change-Id: I23c3fb297d885d8b167ec832e306303da054c083 Reviewed-on: https://chromium-review.googlesource.com/712914

5e06478 🏡 Remove loading suggestions placeholder.
.../chrome/browser/ntp/cards/ActionItem.java | 8 ++
.../chrome/browser/ntp/cards/ItemViewType.java | 9 +--
.../browser/ntp/cards/NewTabPageAdapter.java | 23 +++---
.../browser/ntp/cards/SuggestionsSection.java | 23 +-----
.../suggestions/ContentSuggestionPlaceholder.java | 81 ---------------------
.../browser/suggestions/SuggestionsMetrics.java | 6 +-
chrome/android/java_sources.gni | 1 -
.../browser/ntp/snippets/ArticleSnippetsTest.java | 18 -----
.../browser/ntp/cards/NewTabPageAdapterTest.java | 47 +-----------
...n-content_suggestion_placeholder.Nexus_5-19.png | Bin 3433 -> 0 bytes
tools/metrics/histograms/histograms.xml | 16 ++++
11 files changed, 45 insertions(+), 187 deletions(-)

Upstream: git.chromium.org


  • Share