Add a SetCanonicalCookie method for CookieMonster

Desktop / Chromium - rdsmith [chromium.org] - 21 June 2017 13:11 EDT

This includes some refactoring of creation time defaulting, as well as a histogram revision bump because the information about whether a cookie is being set based on a null URL is no longer available at the point of histogram creation.

BUG=721395, 723734 R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2882063002 Cr-Commit-Position: refs/heads/master@{#481227}

a6ce444 Add a SetCanonicalCookie method for CookieMonster.
.../browser/net/aw_cookie_store_wrapper.cc | 24 +++-
.../browser/net/aw_cookie_store_wrapper.h | 4 +
.../extensions/api/cookies/cookies_unittest.cc | 2 +-
.../util/testing/generic_url_request_mocks.cc | 8 ++
.../util/testing/generic_url_request_mocks.h | 5 +
ios/net/cookies/cookie_store_ios.h | 4 +
ios/net/cookies/cookie_store_ios.mm | 37 +++++-
ios/net/cookies/cookie_store_ios_persistent.h | 4 +
ios/net/cookies/cookie_store_ios_persistent.mm | 12 ++
net/cookies/canonical_cookie.cc | 6 +
net/cookies/canonical_cookie.h | 9 +-
net/cookies/canonical_cookie_unittest.cc | 11 ++
net/cookies/cookie_monster.cc | 85 ++++++++++---
net/cookies/cookie_monster.h | 23 ++--
net/cookies/cookie_monster_unittest.cc | 16 ++-
net/cookies/cookie_store.h | 12 ++
net/cookies/cookie_store_test_helpers.cc | 8 ++
net/cookies/cookie_store_test_helpers.h | 5 +
net/cookies/cookie_store_unittest.h | 140 +++++++++++++++++++++
19 files changed, 381 insertions(+), 34 deletions(-)

Upstream: git.chromium.org


  • Share