Add chrome channel to cert logger reports

Desktop / Chromium - sperigo [chromium.org] - 12 July 2017 16:09 EDT

The cert logger reports are used to gather information on certificate failures, and are helpful for background research for the Enamel team's interstitials. We've added chrome channels to these certificate logs in order to better isolate the root of problems we might see arise.

BUG=738618

TEST=Unit test added in components/certificate_reporting/error_report_unittest.cc.

Review-Url: https://codereview.chromium.org/2964283002 Cr-Commit-Position: refs/heads/master@{#486069}

6f80e9e Add chrome channel to cert logger reports.
chrome/browser/ssl/cert_report_helper.cc | 3 ++
.../ssl/certificate_reporting_test_utils.cc | 32 ++++++++++++++++++----
.../browser/ssl/certificate_reporting_test_utils.h | 13 +++++++--
chrome/browser/ssl/ssl_browser_tests.cc | 6 ++++
components/certificate_reporting/BUILD.gn | 2 ++
components/certificate_reporting/DEPS | 3 +-
components/certificate_reporting/cert_logger.proto | 12 ++++++++
components/certificate_reporting/error_report.cc | 32 +++++++++++++++++++++-
components/certificate_reporting/error_report.h | 8 ++++++
.../certificate_reporting/error_report_unittest.cc | 32 ++++++++++++++++++++++
10 files changed, 133 insertions(+), 10 deletions(-)

Upstream: git.chromium.org


  • Share