Add color space info to CopyOutputResult

Desktop / Chromium - Christopher Cameron [chromium.org] - 8 September 2017 20:51 EDT

The data from CopyOutputResult is from a framebuffer that is in a particular color space (specified by its RenderPass). That color space information was not propagated to the CopyOutputResult. Fix this.

For textures, populate the texture mailbox's color space. Add pixel tests for all of this path.

Do not add support for the SkBitmap path yet. That will come in a future patch.

R=enne, miu, dcheng TBR=rockot

Bug: 758057 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic889c51660ff4af02e082eb2867c956fa2212001 Reviewed-on: https://chromium-review.googlesource.com/651691 Commit-Queue: ccameron chromium

97820e6 Add color space info to CopyOutputResult
cc/trees/layer_tree_host_pixeltest_readback.cc | 52 +++++++++++++++++++++
components/viz/service/display/gl_renderer.cc | 18 ++++---
components/viz/service/display/gl_renderer.h | 4 +-
components/viz/test/data/srgb_green_in_p3.png | Bin 0 -> 593 bytes
components/viz/test/test_layer_tree_frame_sink.cc | 10 ++++
components/viz/test/test_layer_tree_frame_sink.h | 7 +++
.../cpp/compositing/struct_traits_unittest.cc | 4 ++
7 files changed, 88 insertions(+), 7 deletions(-)

Upstream: git.chromium.org


  • Share