Add flag to list all modes of external displays

Desktop / Chromium - Ahmed Fakhry [chromium.org] - 22 February 2019 23:54 EST

This CL adds a flag that enables listing all display modes in the display settings for external displays, which can be very useful for debugging and development purposes.

BUG=927848 TEST=Added tests, tested on device with 4k display

Change-Id: I748f2c2b645071723b94a37f759528b6437558aa Reviewed-on: https://chromium-review.googlesource.com/c/1465682 Commit-Queue: Ahmed Fakhry

15d707e7b35a Add flag to list all modes of external displays
ash/display/cros_display_config.cc | 5 +-
ash/display/display_manager_unittest.cc | 7 +-
ash/display/display_prefs.cc | 18 ++-
ash/display/display_prefs_unittest.cc | 4 +-
ash/public/interfaces/cros_display_config.mojom | 2 +
chrome/app/settings_strings.grdp | 3 +
chrome/browser/about_flags.cc | 8 +-
.../display_info_provider_chromeos.cc | 2 +
chrome/browser/flag-metadata.json | 7 ++
chrome/browser/flag_descriptions.cc | 4 +
chrome/browser/flag_descriptions.h | 3 +
.../resources/settings/device_page/display.js | 30 ++++-
.../md_settings_localized_strings_provider.cc | 6 +
content/browser/browser_main_loop.cc | 4 +-
extensions/common/api/system_display.idl | 3 +
tools/metrics/histograms/enums.xml | 2 +
ui/display/BUILD.gn | 2 +
ui/display/display_features.cc | 32 +++++
ui/display/display_features.h | 27 +++++
ui/display/display_switches.cc | 15 ---
ui/display/display_switches.h | 10 --
ui/display/manager/display_change_observer.cc | 115 ++++++++++++------
ui/display/manager/display_change_observer.h | 4 +-
.../manager/display_change_observer_unittest.cc | 130 ++++++++++++++++-----
ui/display/manager/display_configurator.cc | 51 +++++++-
ui/display/manager/display_configurator.h | 8 +-
.../manager/display_configurator_unittest.cc | 5 +-
ui/display/manager/display_manager.cc | 49 +++++---
ui/display/manager/display_manager.h | 4 +-
ui/display/manager/managed_display_info.cc | 18 +++
ui/display/manager/managed_display_info.h | 28 +++++
31 files changed, 469 insertions(+), 137 deletions(-)

Upstream: git.chromium.org


  • Share