Add more AOM Phase 2 event listeners

Desktop / Chromium - Dominic Mazzoni [chromium.org] - 31 August 2017 17:37 EDT

This change adds support for these new events: accessiblecontextmenu accessibledecrement accessiblefocus accessibleincrement accessiblescrollintoview

The pattern for all of these is the same - when the action is triggered on an AXObject, we first try to fire an AOM event, and if that's not handled, we want to fall back on the default behavior.

To make that more readable, this change renames all of the action interfaces in AXObject to each consist of a pair of methods - one public method to be triggered from the outside, and an internal method to handle the native fallback behavior.

Bug: 746524 Change-Id: Idee1450de57bef57ebac53860a486c30b909a225 Reviewed-on: https://chromium-review.googlesource.com/634927 Commit-Queue: Dominic Mazzoni

b891faf Add more AOM Phase 2 event listeners.
.../accessibility/render_accessibility_impl.cc | 11 +-
content/shell/test_runner/web_ax_object_proxy.cc | 23 +--
.../LayoutTests/accessibility/aom-actions.html | 112 +++++++++++++
.../global-interface-listing-expected.txt | 10 ++
.../WebKit/Source/core/dom/AccessibleNode.h | 5 +
.../WebKit/Source/core/dom/AccessibleNode.idl | 5 +
.../WebKit/Source/core/events/EventTypeNames.json5 | 5 +
.../modules/accessibility/AXLayoutObject.cpp | 30 ++--
.../Source/modules/accessibility/AXLayoutObject.h | 8 +-
.../modules/accessibility/AXListBoxOption.cpp | 9 +-
.../Source/modules/accessibility/AXListBoxOption.h | 2 +-
.../Source/modules/accessibility/AXMenuList.cpp | 2 +-
.../Source/modules/accessibility/AXMenuList.h | 2 +-
.../modules/accessibility/AXMenuListOption.cpp | 5 +-
.../modules/accessibility/AXMenuListOption.h | 2 +-
.../modules/accessibility/AXMenuListPopup.cpp | 5 +-
.../Source/modules/accessibility/AXMenuListPopup.h | 2 +-
.../Source/modules/accessibility/AXNodeObject.cpp | 57 ++++---
.../Source/modules/accessibility/AXNodeObject.h | 8 +-
.../Source/modules/accessibility/AXObject.cpp | 175 ++++++++++++++++++---
.../WebKit/Source/modules/accessibility/AXObject.h | 57 ++++---
.../Source/modules/accessibility/AXSlider.cpp | 5 +-
.../WebKit/Source/modules/accessibility/AXSlider.h | 2 +-
.../Source/modules/accessibility/AXSpinButton.cpp | 2 +-
.../Source/modules/accessibility/AXSpinButton.h | 2 +-
.../WebKit/Source/modules/exported/WebAXObject.cpp | 134 +++++-----------
third_party/WebKit/public/web/WebAXObject.h | 55 +++----
27 files changed, 483 insertions(+), 252 deletions(-)

Upstream: git.chromium.org


  • Share