Add runtime flag to turn off getMatchedCSSRules

Desktop / Chromium - Darren Shen [chromium.org] - 11 September 2017 19:00 EDT

This patch adds a runtime flag for getMatchedCSSRules and turns it off completely. This will allow us to disable getMatchedCSSRules in M63 whilst making it easier to turn the feature back on again in case anything goes wrong.

[1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/fd-QLCiLESQ/_mfowSsRR8oJ

[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/-_Al0I5Rm9Q/PDzupcoxAwAJ

Bug: 437569 Change-Id: I2d022a3b03d4ec1297248563acd598c9fc7ccf9a Reviewed-on: https://chromium-review.googlesource.com/644831 Commit-Queue: Darren Shen

d8898de Add runtime flag to turn off getMatchedCSSRules.
.../content_scripts/css_l10n/test_extension_id.js | 9 +-
.../enable-blink-features=LayoutNG | 7 -
.../external/wpt/compat/historical-expected.txt | 6 -
.../repeat/margin-shorthand-expected.txt | 1 -
.../repeat/resources/margin-shorthand.js | 2 +-
.../css/border-radius-property-value-expected.txt | 1 -
.../fast/css/border-radius-property-value.html | 2 +-
.../fast/css/modify-ua-rules-from-javascript.html | 28 ----
...d-break-user-modify-allowed-values-expected.txt | 4 +-
.../css/word-break-user-modify-allowed-values.html | 12 +-
...tached-parent-rule-without-wrapper-expected.txt | 4 +-
.../detached-parent-rule-without-wrapper.html | 8 +-
...etached-stylesheet-without-wrapper-expected.txt | 1 -
.../detached-stylesheet-without-wrapper.html | 2 +-
...ed-media-rule-deleted-parent-crash-expected.txt | 3 +-
.../removed-media-rule-deleted-parent-crash.html | 2 +-
...ylesheet-rule-deleted-parent-crash-expected.txt | 1 -
...moved-stylesheet-rule-deleted-parent-crash.html | 4 +-
.../dom/Window/get-set-properties-expected.txt | 2 -
.../fast/dom/Window/get-set-properties.html | 1 -
.../getMatchedCSSRules-nested-rules-expected.txt | 15 --
.../Window/getMatchedCSSRules-nested-rules.html | 27 ----
.../getMatchedCSSRules-null-crash-expected.txt | 2 -
.../dom/Window/getMatchedCSSRules-null-crash.html | 6 -
...MatchedCSSRules-parent-stylesheets-expected.txt | 16 ---
.../getMatchedCSSRules-parent-stylesheets.html | 29 ----
...Rules-with-invalid-pseudo-elements-expected.txt | 21 ---
...tchedCSSRules-with-invalid-pseudo-elements.html | 28 ----
...Rules-with-pseudo-elements-complex-expected.txt | 13 --
...tchedCSSRules-with-pseudo-elements-complex.html | 125 ----------------
...tchedCSSRules-with-pseudo-elements-expected.txt | 12 --
.../getMatchedCSSRules-with-pseudo-elements.html | 29 ----
.../fast/dom/Window/resources/WindowProperties.js | 1 -
.../fast/dom/Window/resources/window-properties.js | 1 -
...w-function-frame-getter-precedence-expected.txt | 1 -
...ow-function-name-getter-precedence-expected.txt | 1 -
.../Window/window-lookup-precedence-expected.txt | 2 -
.../LayoutTests/fast/dom/defaultView-expected.txt | 2 -
.../WebKit/LayoutTests/fast/dom/defaultView.html | 5 -
...ed-css-rules-with-dirty-dirstibution-crash.html | 9 --
.../fast/inspector-support/matchedrules.html | 17 ---
.../fast/inspector-support/style-expected.txt | 1 -
.../LayoutTests/fast/inspector-support/style.html | 2 +-
.../fast/js/global-function-resolve-expected.txt | 158 ++++++++++-----------
.../js/script-tests/global-function-resolve.js | 1 -
.../security/cross-frame-access-call-expected.txt | 1 -
.../tests/security/cross-frame-access-call.html | 1 -
.../security/cross-frame-access-put-expected.txt | 2 +-
.../security/cross-origin-getMatchedCSSRules.html | 43 ------
.../security/cross-origin-getMatchedCSSRules2.html | 27 ----
.../inspector-support/matchedrules-expected.txt | 12 --
.../global-interface-listing-expected.txt | 1 -
.../inspector-support/matchedrules-expected.txt | 12 --
.../global-interface-listing-expected.txt | 1 -
.../reporting-observer/resources/deprecation.js | 2 +-
.../global-interface-listing-expected.txt | 1 -
third_party/WebKit/Source/core/frame/Window.idl | 2 +-
.../Source/platform/RuntimeEnabledFeatures.json5 | 3 +
58 files changed, 111 insertions(+), 621 deletions(-)

Upstream: git.chromium.org


  • Share