Add Support for App Display Names to GetShownOriginAndLinkUrl

Desktop / Chromium - jdoerrie [chromium.org] - 14 July 2017 06:39 EDT

This change adds support for app display names to Password UI Utils. This is useful for the more human friendly display of Android credentials, as this will display the Play Store name of the App, if available.

Bug: 628988, 617094, 679434 Change-Id: Ide7bc694805ce40cbbccf8e8496c32bcb677de25 Reviewed-on: https://chromium-review.googlesource.com/567936 Commit-Queue: Jan Wilken Dörrie

b9fc076 Add Support for App Display Names to GetShownOriginAndLinkUrl
chrome/browser/android/password_ui_view_android.cc | 35 ++---------
chrome/browser/android/password_ui_view_android.h | 2 +
.../passwords_private/passwords_private_utils.cc | 49 ++-------------
.../passwords_private/passwords_private_utils.h | 4 +-
.../passwords_private_utils_unittest.cc | 34 +++++------
.../ui/passwords/password_manager_presenter.cc | 61 ++++++++++---------
.../password_manager_presenter_unittest.cc | 29 +++++----
.../ui/webui/options/password_manager_handler.cc | 27 +++++----
.../core/browser/password_ui_utils.cc | 53 +++++++---------
.../core/browser/password_ui_utils.h | 32 ++++------
.../core/browser/password_ui_utils_unittest.cc | 70 +++++++++-------------
11 files changed, 154 insertions(+), 242 deletions(-)

Upstream: git.chromium.org


  • Share