Add the VariationsFieldTrialCreator class

Desktop / Chromium - Kyle Milka [google.com] - 13 July 2017 21:14 EDT

This is part 3 of 6 for FieldTrial refactoring for WebView

Part 1: https://chromium-review.googlesource.com/c/562098/ Part 2: https://chromium-review.googlesource.com/c/561920/ Part 3: https://chromium-review.googlesource.com/c/561922/ Part 4: https://chromium-review.googlesource.com/c/561980/ Part 5: https://chromium-review.googlesource.com/c/562417/ Part 6: https://chromium-review.googlesource.com/c/562021/

This CL creates the VariationsFieldTrialCreator class. This class contains the code previously in VariationsService that is needed by both Chrome and WebView, mainly the portions needed to call CreateTrialsFromSeed. The VariationsService class now contains an instance of this new class.

BUG=678288

Change-Id: Ic4340d5a0396cca56892a3b541e4cf6115bb8afb Reviewed-on: https://chromium-review.googlesource.com/561922 Commit-Queue: Kyle Milka

34b11e8 Add the VariationsFieldTrialCreator class
components/variations/service/BUILD.gn | 3 +
.../service/field_trial_creator_unittest.cc | 260 +++++++++++++++
.../service/variations_field_trial_creator.cc | 329 +++++++++++++++++++
.../service/variations_field_trial_creator.h | 122 +++++++
.../variations/service/variations_service.cc | 349 +++------------------
components/variations/service/variations_service.h | 31 +-
.../service/variations_service_unittest.cc | 76 -----
7 files changed, 765 insertions(+), 405 deletions(-)

Upstream: git.chromium.org


  • Share