Added Bookmark feature in IPH.

Desktop / Chromium - Bettina Dea [chromium.org] - 5 September 2017 23:23 EDT

Changes in this Patch:
- Added event and feature constants for Bookmarks.
- Added the BookmarkInProductHelp trial to the fieldtrial json.- Created a BookmarkTracker class, which contains methods to notify the IPH server when events happen and if the help UI should be triggered.
- Created a BookmarkTrackerFactory class and registered in the chrome browser main parts.
- Added unit tests for BookmarkTracker event logging and expected functionality.

Design Doc: https://docs.google.com/a/chromium.org/document/d/1j_npx4R1V8IhWY1bHCwvAVpzWUbAl26tlY5jpJ_Rdgc/edit?usp=sharing

This is following the intern's, Chris, CL that wasn't submitted: https://chromium-review.googlesource.com/c/581872

Bug: 734132 Change-Id: Ifc4b4e07ce5f2427f9210dac739df67637cfd66e Reviewed-on: https://chromium-review.googlesource.com/614367 Commit-Queue: Bettina Dea

48125dc Added Bookmark feature in IPH.
chrome/browser/BUILD.gn | 4 +
.../bookmark/bookmark_tracker.cc | 70 ++++++
.../feature_engagement/bookmark/bookmark_tracker.h | 63 ++++++
.../bookmark/bookmark_tracker_factory.cc | 52 +++++
.../bookmark/bookmark_tracker_factory.h | 52 +++++
.../bookmark/bookmark_tracker_unittest.cc | 237 +++++++++++++++++++++
.../chrome_browser_main_extra_parts_profiles.cc | 6 +-
chrome/browser/ui/browser_command_controller.cc | 16 +-
chrome/test/BUILD.gn | 1 +
.../feature_engagement/public/event_constants.cc | 5 +-
.../feature_engagement/public/event_constants.h | 19 +-
.../feature_engagement/public/feature_constants.cc | 4 +-
.../feature_engagement/public/feature_constants.h | 3 +-
.../feature_engagement/public/feature_list.cc | 3 +-
.../feature_engagement/public/feature_list.h | 6 +-
testing/variations/fieldtrial_testing_config.json | 25 +++
tools/metrics/actions/actions.xml | 36 ++++
tools/metrics/histograms/histograms.xml | 1 +
18 files changed, 588 insertions(+), 15 deletions(-)

Upstream: git.chromium.org


  • Share