app_list: add suggested apps to all apps launcher page

Desktop / Chromium - Qiang Xu [chromium.org] - 12 July 2017 20:38 EDT

changes: (1) refactor AppsGridView's ctor to accept ContentsView*. (2) move all apps indicator from AppsContainerView to AppsGridView. (3) host suggested_apps_indicator_, all_apps_indicator_, and suggestions container view in AppsGridView. (4) for all apps layout, the first page is 4*5 and all others are 5*5. (5) update keyboard arrow moving focus for new launcher. See focus rules in inline comments. (6) refactor AppsGridViewTest by creating app_list_view_ to test AppsGridView, also make it parameterized tests to test EnableFullscreenAppList. Most of the tests are opened for both old and new launcher. (7) add tests: CreatePage, HandleSuggestionsMove, MoveSelectedOnAllAppsTiles.

UI specification: https://screenshot.googleplex.com/ebJ2ug1xS9Z.

flag, screenshot: https://screenshot.googleplex.com/AbpxexGtKNj keyboard moving focus works as expected. also added test coverage.

Bug: 735702 TEST: tested with and without --enable-features=EnableFullscreenAppList Change-Id: I7fe602c84bdeb8f659013de76285fb2dca9f6ec3 Reviewed-on: https://chromium-review.googlesource.com/564485

0bb07b6 app_list: add suggested apps to all apps launcher page
ui/app_list/views/app_list_folder_view.cc | 2 +-
ui/app_list/views/app_list_main_view.h | 8 +-
ui/app_list/views/apps_container_view.cc | 26 +-
ui/app_list/views/apps_container_view.h | 2 -
ui/app_list/views/apps_grid_view.cc | 427 +++++++++++++++++-----
ui/app_list/views/apps_grid_view.h | 84 +++--
ui/app_list/views/apps_grid_view_unittest.cc | 377 ++++++++++++++-----
ui/app_list/views/test/apps_grid_view_test_api.cc | 8 +
ui/app_list/views/test/apps_grid_view_test_api.h | 8 +
9 files changed, 692 insertions(+), 250 deletions(-)

Upstream: git.chromium.org


  • Share