Changing holdback bool to holdback experiment group name

Desktop / Chromium - ryansturm [chromium.org] - 14 June 2017 19:00 EDT

This changes the DRP pingback to pass a string of the holdback group name instead of just a bool. This allows comparison of the control vs enabled groups and allows the finch config to change if the holdback behavior changes or more groups are added.

BUG=731180

Review-Url: https://codereview.chromium.org/2942683002 Cr-Commit-Position: refs/heads/master@{#479534}

86edd62 Changing holdback bool to holdback experiment group name
.../data_reduction_proxy_pingback_client.cc | 2 +-
...ata_reduction_proxy_pingback_client_unittest.cc | 4 +-
.../core/common/data_reduction_proxy_params.cc | 46 ++++++++++++----------
.../core/common/data_reduction_proxy_params.h | 4 ++
.../common/data_reduction_proxy_params_unittest.cc | 1 +
.../proto/pageload_metrics.proto | 6 +--
6 files changed, 36 insertions(+), 27 deletions(-)

Upstream: git.chromium.org


  • Share