Clean up around HTMLImportLoader construction

Desktop / Chromium - Takeshi Yoshino [chromium.org] - 9 August 2017 04:08 EDT

- Move the logic to ensure the Document has an HTMLImportsController to Document as EnsureImportsController().- Remove the methods for debugging Show(), ShowTree() and ShowThis( )on the HTMLImport class which is no longer used even in the debug build.- Remove HTMLImportChild::SetClient() and pass an HTMLImportChildClient directly via the constructor instead.- Add const version of GetDocument() to the LinkResource class to reduce "owner_->" occurrences.

Bug: 673669 Change-Id: I5b2584f34ad47d6983ebebe30746a2b9d419f464 Reviewed-on: https://chromium-review.googlesource.com/586218 Commit-Queue: Takeshi Yoshino

1459500 Clean up around HTMLImportLoader construction
third_party/WebKit/Source/core/dom/Document.cpp | 12 ++++---
third_party/WebKit/Source/core/dom/Document.h | 2 +-
.../WebKit/Source/core/html/LinkResource.cpp | 20 +++++++-----
third_party/WebKit/Source/core/html/LinkResource.h | 1 +
.../WebKit/Source/core/html/imports/HTMLImport.cpp | 21 ------------
.../WebKit/Source/core/html/imports/HTMLImport.h | 6 ----
.../Source/core/html/imports/HTMLImportChild.cpp | 38 ++++++++--------------
.../Source/core/html/imports/HTMLImportChild.h | 11 +++----
.../core/html/imports/HTMLImportsController.cpp | 14 +++++---
.../core/html/imports/HTMLImportsController.h | 2 +-
.../WebKit/Source/core/html/imports/LinkImport.cpp | 15 ++-------
11 files changed, 51 insertions(+), 91 deletions(-)

Upstream: git.chromium.org


  • Share