Complete jump commands in Docs

Desktop / Chromium - David Tseng [chromium.org] - 17 July 2017 15:13 EDT

- treat the Docs content editable as a root (note that the role=textbox has a parent that is also richly editable; the only way to distinguish is based on focus. Could have used role as well, but focused state seems more relevant). This means that jumping to the next link while ChromeVox range is inside of a content editable wraps inside the content editable. Also, control duplicate/overlapping output by suppressing the usual output in navigation when the node is richly editable.
- fix an issue where we were clearing text edit handler state on focus. We actually set focus after every jump command, so this resulted in us speaking "deleted" after every jump command.
- handle another state transition in AutomationRichEditableText. This one is non-overlapping selections from prev to cur. These occur as a result of jump commands among other possibilities. TEST=jump around in a complex document.

Bug: Change-Id: I1f5b555e143a2998576b746671761eeb0705ede1 Reviewed-on: https://chromium-review.googlesource.com/574787

cfa41a0 Complete jump commands in Docs
.../cvox2/background/automation_predicate.js | 2 +-
.../chromevox/cvox2/background/background.js | 4 ++++
.../chromevox/cvox2/background/command_handler.js | 8 +++++++-
.../cvox2/background/desktop_automation_handler.js | 3 ++-
.../chromeos/chromevox/cvox2/background/editing.js | 23 ++++++++++++++++------
5 files changed, 31 insertions(+), 9 deletions(-)

Upstream: git.chromium.org


  • Share