Connecting frontend and backend code for the NewTabTracker

Desktop / Chromium - Catherine Chung [google.com] - 9 August 2017 04:10 EDT

- Browsertest added to confirm the tracker can call the promo UI- Added static helper in NewTabButton to show the promo for the last active browser- The method DismissNewTracker was renamed to OnPromoClosed

Bug: 734132, 737830 Change-Id: Ia6881474661b44c3994cc641b10333cd96fc1172 Reviewed-on: https://chromium-review.googlesource.com/596274 Commit-Queue: Catherine Chung

5795ebb Connecting frontend and backend code for the NewTabTracker
chrome/browser/feature_engagement/DEPS | 7 ++
.../feature_engagement/new_tab/new_tab_tracker.cc | 15 ++-
.../feature_engagement/new_tab/new_tab_tracker.h | 9 +-
.../new_tab/new_tab_tracker_browsertest.cc | 135 +++++++++++++++++++++
chrome/browser/ui/views/tabs/new_tab_button.cc | 13 +-
chrome/browser/ui/views/tabs/new_tab_button.h | 3 +
chrome/test/BUILD.gn | 2 +
7 files changed, 168 insertions(+), 16 deletions(-)

Upstream: git.chromium.org


  • Share