cros: Make FakeGaia in OobeBaseTest a mixin

Desktop / Chromium - Jacob Dufault [google.com] - 25 February 2019 20:43 EST

We may want to just use FakeGaia directly instead of introducing a mixin, but that can be decided later. For now let's focus on simplifying all of the test bases.

Bug: 912704 Change-Id: Id4a7ab8e0c23343b7e6e59c7b7d2aefc16891515 Reviewed-on: https://chromium-review.googlesource.com/c/1366895 Commit-Queue: Jacob Dufault

c0c53eb21b96 cros: Make FakeGaia in OobeBaseTest a mixin
.../accessibility/spoken_feedback_browsertest.cc | 1 +
.../screen_time_controller_browsertest.cc | 1 +
.../chromeos/login/enable_debugging_browsertest.cc | 1 +
chrome/browser/chromeos/login/eula_browsertest.cc | 1 +
chrome/browser/chromeos/login/kiosk_browsertest.cc | 13 ++-
.../browser/chromeos/login/login_manager_test.cc | 57 +----------
chrome/browser/chromeos/login/login_manager_test.h | 20 ----
.../browser/chromeos/login/login_ui_browsertest.cc | 1 +
.../login/login_ui_keyboard_browsertest.cc | 1 +
.../chromeos/login/login_utils_browsertest.cc | 6 +-
chrome/browser/chromeos/login/oobe_browsertest.cc | 13 ++-
.../chromeos/login/oobe_interactive_ui_test.cc | 12 ++-
chrome/browser/chromeos/login/reset_browsertest.cc | 1 +
.../chromeos/login/saml/saml_browsertest.cc | 60 ++++++------
.../screens/user_selection_screen_browsertest.cc | 1 +
.../session/chrome_session_manager_browsertest.cc | 19 +++-
.../chromeos/login/signin/device_id_browsertest.cc | 91 +++++++++++-------
.../chromeos/login/signin/oauth2_browsertest.cc | 24 +++--
.../browser/chromeos/login/test/fake_gaia_mixin.cc | 107 +++++++++++++++++++++
.../browser/chromeos/login/test/fake_gaia_mixin.h | 93 ++++++++++++++++++
.../browser/chromeos/login/test/oobe_base_test.cc | 64 ++----------
.../browser/chromeos/login/test/oobe_base_test.h | 42 +-------
.../users/avatar/user_image_manager_browsertest.cc | 12 ++-
.../login/users/wallpaper_policy_browsertest.cc | 26 ++---
.../chromeos/login/webview_login_browsertest.cc | 17 ++--
.../chromeos/policy/login_policy_test_base.cc | 9 +-
.../chromeos/policy/login_policy_test_base.h | 3 +
...user_cloud_external_data_manager_browsertest.cc | 2 +-
chrome/test/BUILD.gn | 2 +
29 files changed, 410 insertions(+), 290 deletions(-)

Upstream: git.chromium.org


  • Share