cros: Use webview for Eula screen

Desktop / Chromium - Xiyuan Xia [chromium.org] - 19 October 2017 16:42 EDT

- Replace eula iframes with webview;- Load chrome://terms via XHR and set to webviews via data url to re-use existing online/local/oem terms loading code;- Get rid of padding for .eula-frame css class as webview looks good without it;- Move online terms loading from ChromeOSTermsHandler to Oobe Eula webui;- Re-write EulaTest since old tests are testing chrome://terms in a tab;- Move EulaTest from interactive_ui_tests to browser_tests since it no longer uses ui_test_utils::FindInPage;

Bug: 770313 Test: Manual. Verify Eula screen works with MD/non-MD/language change. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2d90492958d0adae06a3e873942f2d3f534f7991 Reviewed-on: https://chromium-review.googlesource.com/710738

c09ae9d cros: Use webview for Eula screen
chrome/browser/chromeos/login/eula_browsertest.cc | 264 +++++++++++++++------
chrome/browser/resources/chromeos/login/oobe.js | 7 +-
.../browser/resources/chromeos/login/oobe_eula.css | 6 +
.../resources/chromeos/login/oobe_eula.html | 6 +-
.../browser/resources/chromeos/login/oobe_eula.js | 2 +-
.../resources/chromeos/login/oobe_screen_eula.css | 6 +-
.../resources/chromeos/login/oobe_screen_eula.html | 8 +-
.../resources/chromeos/login/oobe_screen_eula.js | 213 ++++++++++++++++-
chrome/browser/ui/webui/about_ui.cc | 121 ++--------
chrome/browser/ui/webui/about_ui.h | 3 +-
.../ui/webui/chromeos/login/eula_screen_handler.cc | 9 +-
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 6 +-
chrome/test/BUILD.gn | 2 +-
13 files changed, 438 insertions(+), 215 deletions(-)

Upstream: git.chromium.org


  • Share