DevTools: do not use file system API for temp files

Desktop / Chromium - Andrey Kosyakov [chromium.org] - 13 July 2017 00:58 EDT

This removes usage of the File System API in DevTools and uses blobs instead to manage temporary files. Also gone are:

- a bunch of methods to support deferred temporary files and handle asynchrony and potential failures that are no longer there;- mock for temp files and associated readers in tests -- we can now afford to test actual code;
- a couple of tests that specifically tested for FS-based temp files.

Bug: 490148, 553246 Change-Id: Ie321c713746016c866cdd30fe6940566f0b6ace3 Reviewed-on: https://chromium-review.googlesource.com/569119 Commit-Queue: Andrey Kosyakov

14fe0c2 DevTools: do not use file system API for temp files
.../devtools/devtools_sanity_browsertest.cc | 21 --
.../enable-blink-features=LayoutNG | 1 -
.../http/tests/inspector/inspector-test.js | 94 -------
.../http/tests/inspector/timeline-test.js | 57 +----
.../inspector/profiler/cpu-profiler-save-load.html | 6 +-
.../inspector/profiler/profiler-test.js | 1 -
.../profiler/temp-storage-cleaner-expected.txt | 4 -
.../inspector/profiler/temp-storage-cleaner.html | 26 --
.../tracing/tracing-timeline-load-expected.txt | 4 -
.../inspector/tracing/tracing-timeline-load.html | 9 +-
third_party/WebKit/Source/devtools/BUILD.gn | 6 -
.../WebKit/Source/devtools/front_end/Runtime.js | 40 ---
.../WebKit/Source/devtools/front_end/Tests.js | 10 -
.../devtools/front_end/audits2/Audits2Panel.js | 2 +-
.../devtools/front_end/bindings/FileUtils.js | 8 +-
.../Source/devtools/front_end/bindings/TempFile.js | 278 +++------------------
.../devtools/front_end/network/NetworkPanel.js | 2 +-
.../front_end/profiler/HeapSnapshotView.js | 8 +-
.../devtools/front_end/profiler/ProfileView.js | 75 +-----
.../devtools/front_end/services/ServiceManager.js | 30 +--
.../front_end/timeline/TimelineController.js | 2 +-
.../devtools/front_end/timeline/TimelineLoader.js | 2 +-
.../devtools/front_end/utility_shared_worker.js | 7 -
.../devtools/front_end/utility_shared_worker.json | 8 -
.../front_end/utility_shared_worker/TempStorage.js | 80 ------
.../front_end/utility_shared_worker/module.json | 15 --
.../front_end/worker_service/ServiceDispatcher.js | 14 +-
.../Source/devtools/scripts/compile_frontend.py | 1 -
.../scripts/extract_module/extract_module.js | 1 -
.../Source/devtools/scripts/gulp/gulpfile.js | 1 -
30 files changed, 78 insertions(+), 735 deletions(-)

Upstream: git.chromium.org


  • Share