Do not send overscroll updates to animating affordance

Desktop / Chromium - Mohsen Izadi [chromium.org] - 14 July 2017 00:05 EDT

When:- a simple gesture nav affordance is performing a complete or abort animation; and- a new overscroll is started; and- the new overscroll is going to be ignored because, for example, there is no item in the navigation history to navigate to; the overscroll updates should be ignored. Currently, they would be sent to the animating affordance until its animation is complete and the instance is deleted.

An example situation this can happen is when there is no page to navigate back to, but there is a page to navigate forward to. If you start a forward overscroll with touchpad, then swipe quickly in the opposite direction, the forward overscroll will be aborted and a back overscroll will be started. However, since there is no page to navigate back to, no new affordance is created and overscroll updates would be sent to the existing animating forward affordance. This bug is introduced in r477865.

BUG=668296 TEST=manual

Change-Id: I110addf3a58132edd70384b881835cfe6c4c93c2 Reviewed-on: https://chromium-review.googlesource.com/565759

1cff10c Do not send overscroll updates to animating affordance
content/browser/web_contents/aura/gesture_nav_simple.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Upstream: git.chromium.org


  • Share