Dont activate non modal system window by default

Desktop / Chromium - Mitsuru Oshima [chromium.org] - 11 September 2017 01:42 EDT

FB chathead mode uses system window and it shouldn't be activated by default to avoid stealing focus. Ideally, we shoud be able to sepectively activate/deactivate for each app. Unfortunately, that's not possible because these window doesn't have task id. (b/65460424)

This CL simply skip activating the window if it's not modal, and deactivate if the window becomes non modal and it wasn't active.

Bug: 62657277 Test: See bu for repro step. Covered by unit tests. Change-Id: Id4729ea70153dd70024867156385f485cf6bfaad Reviewed-on: https://chromium-review.googlesource.com/657570 Commit-Queue: Mitsuru Oshima

acdcf55 Dont activate non modal system window by default.
components/exo/shell_surface.cc | 24 +++++++++++++++----
components/exo/shell_surface.h | 1 +
components/exo/shell_surface_unittest.cc | 41 +++++++++++++++++++++++++++++++-
3 files changed, 61 insertions(+), 5 deletions(-)

Upstream: git.chromium.org


  • Share