Experimental Fullscreen Prototype Refinements

Desktop / Chromium - Robert Liao [chromium.org] - 13 September 2017 21:24 EDT

- Changed the button into a circle to see how this feels.
- Moved from ET_GESTURE_LONG_PRESS to ET_GESTURE_LONG_TAP to sync with the context menu show and reduce the chance of accidentally dismissing the view. It is possible to long press and then accidentally trigger a move, accidentally hiding the button.
- Require symmetric show and hide input methods: A touch show can only be dismissed by a touch hide. This makes the view robust to spurious mouse events from a touch event.

BUG=710991

Change-Id: Ib2593e9b5e79d9d9334b11ea60990500f6cd89ca Reviewed-on: https://chromium-review.googlesource.com/665599 Commit-Queue: Robert Liao

da6615f6 Experimental Fullscreen Prototype Refinements
chrome/app/generated_resources.grd | 7 ---
.../fullscreen_control/fullscreen_control_host.cc | 63 ++++++++++++----------
.../fullscreen_control/fullscreen_control_host.h | 17 +++++-
.../fullscreen_control/fullscreen_control_view.cc | 47 ++++++++++------
4 files changed, 82 insertions(+), 52 deletions(-)

Upstream: git.chromium.org


  • Share