Files app: Add share options menu on toolbar

Desktop / Chromium - Naoki Fukino [chromium.org] - 13 July 2017 04:10 EDT

This CL to divide tasks to open tasks and other tasks. open tasks: Files app internal tasks and file_hander tasks with OPEN_WITH verb. other tasks: all other tasks.

The OPEN combubutton should have only open tasks, and the new option menu should have the other tasks. The new option menu has share icon as most of tasks should be SHARE_WITH tasks, but other kind of tasks (e.g. PACK_WITH) can also be included.

Existing share{_white}.png was renamed as person_add{_white}.png and the new icon for share button was named as share{_white}.png, to be consistent with the naming in go/icons.

Bug: 740819 Change-Id: Ic5e82aed490af9372e300c5153b5a384b6656464 Reviewed-on: https://chromium-review.googlesource.com/567917

ef2e848 Files app: Add share options menu on toolbar.
chrome/app/chromeos_strings.grdp | 3 +
.../extensions/file_manager/private_api_strings.cc | 1 +
.../file_manager/foreground/css/file_manager.css | 18 +++-
.../foreground/images/files/ui/2x/person_add.png | Bin 0 -> 527 bytes
.../images/files/ui/2x/person_add_white.png | Bin 0 -> 386 bytes
.../foreground/images/files/ui/2x/share.png | Bin 527 -> 791 bytes
.../foreground/images/files/ui/2x/share_white.png | Bin 386 -> 530 bytes
.../foreground/images/files/ui/person_add.png | Bin 0 -> 371 bytes
.../images/files/ui/person_add_white.png | Bin 0 -> 280 bytes
.../foreground/images/files/ui/share.png | Bin 371 -> 415 bytes
.../foreground/images/files/ui/share_white.png | Bin 280 -> 288 bytes
.../file_manager/foreground/js/file_tasks.js | 102 ++++++++++++++++-----
.../file_manager/foreground/js/task_controller.js | 94 ++++++++++---------
.../foreground/js/task_controller_unittest.js | 15 ++-
.../foreground/js/ui/file_manager_ui.js | 17 ++++
ui/file_manager/file_manager/main.html | 12 +++
16 files changed, 184 insertions(+), 78 deletions(-)

Upstream: git.chromium.org


  • Share