Implement the sign-in promo in bookmarks as a card

Desktop / Chromium - Jérôme Lebel [chromium.org] - 9 August 2017 05:50 EDT

Adding margin for the sign-in promo view and removing separator for the bookmark view.

iPhone, before: https://drive.google.com/open?id=0ByXziH_JVCGJaFFQRkNybndCYjg iPhone, after: https://drive.google.com/open?id=0ByXziH_JVCGJMV9Dd08yOW5qTWc

iPad, before: https://drive.google.com/open?id=0ByXziH_JVCGJaThBbGhHVy1JdW8 iPad, after: https://drive.google.com/open?id=0ByXziH_JVCGJZG14YUlGSnhwZHM

Mock: https://drive.google.com/corp/drive/u/0/folders/0B3pahfDhxF6yTXNSY0JQaVNIb2M

Bug: 747744, 747743 Change-Id: I9204c68813266c4c83823fb80558cb5abaac3b22 Reviewed-on: https://chromium-review.googlesource.com/581492 Commit-Queue: Jérôme Lebel

4f6be5b Implement the sign-in promo in bookmarks as a card
.../browser/ui/bookmarks/bookmark_collection_view.mm | 5 +++++
.../browser/ui/bookmarks/bookmark_signin_promo_cell.mm | 17 +++++++++++++++--
2 files changed, 20 insertions(+), 2 deletions(-)

Upstream: git.chromium.org


  • Share