Introduce PopupTracker

Desktop / Chromium - Charles Harrison [chromium.org] - 8 September 2017 17:17 EDT

A PopupTracker is attached to any WebContents that is classified as a popup. E.g. it is handled by the popup blocker.

It's purpose is to log metrics, with the end goal being to have a metric for engagement time on a popup landing page (e.g. the first non blank document).

Bug: 762617 Change-Id: I198ba1fc58b8211d78fcae32f3f74148da7025cb Reviewed-on: https://chromium-review.googlesource.com/653804 Commit-Queue: Charlie Harrison

b72e5d9 Introduce PopupTracker
chrome/browser/ui/BUILD.gn | 2 +
.../ui/blocked_content/popup_blocker_tab_helper.cc | 11 +++
.../ui/blocked_content/popup_blocker_tab_helper.h | 6 ++
chrome/browser/ui/blocked_content/popup_tracker.cc | 12 ++++
chrome/browser/ui/blocked_content/popup_tracker.h | 32 +++++++++
.../blocked_content/popup_tracker_browsertest.cc | 83 ++++++++++++++++++++++
chrome/browser/ui/browser.cc | 20 ++++--
chrome/test/BUILD.gn | 1 +
8 files changed, 160 insertions(+), 7 deletions(-)

Upstream: git.chromium.org


  • Share