Local NTP: support simple doodles

Desktop / Chromium - Chris Pickel [chromium.org] - 20 September 2017 03:38 EDT

Checked against the ddljson test doodles, plus today's doodle in Mexico. A lot more testing is needed, for doodles changing at various times, but that's something that I think automated tests will be better for, since timing is tricky.

Animated doodles still to come.

The Google logo fades out before a doodle fades in. Maybe it would be preferable to start with nothing, but that complicates support for NTPs with the feature disabled. This will come up in implementation review.

Bug: 761942 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9469cb6cdbcee3b60680dade357faee301175257 Reviewed-on: https://chromium-review.googlesource.com/671012 Commit-Queue: Chris Pickel

569806f Local NTP: support simple doodles
chrome/browser/resources/local_ntp/local_ntp.css | 25 +++-
chrome/browser/resources/local_ntp/local_ntp.html | 5 +
chrome/browser/resources/local_ntp/local_ntp.js | 140 +++++++++++++++++++++
chrome/browser/search/local_ntp_source.cc | 18 +--
.../test/data/local_ntp/local_ntp_browsertest.html | 25 ++--
5 files changed, 196 insertions(+), 17 deletions(-)

Upstream: git.chromium.org

  • Share