Log the PasswordReuseDetected event on detecting sync password reuse

Desktop / Chromium - Varun Khaneja [chromium.org] - 8 August 2017 12:04 EDT

Gated by feature flag: "SyncPasswordReuseEvent" Tested by going to chrome://sync-internals and found this: { "specifics": { "user_event": { "event_time_usec": "13146603948381514", "navigation_id": "13146603938830806", "session_id": "-7041365897159180183", "sync_password_reuse_event": { "reuse_detected": { "status": { "enabled": true, "safe_browsing_reporting_population": "SCOUT" } } } } } }

Bug: 735742 Change-Id: Ia15ea8ba31043455c4d4a7c8acfd89113208a68b Reviewed-on: https://chromium-review.googlesource.com/602688 Commit-Queue: Varun Khaneja

da5d0c7 Log the PasswordReuseDetected event on detecting sync password reuse.
.../chrome_password_manager_client.cc | 8 +++
.../chrome_password_manager_client.h | 2 +
.../chrome_password_manager_client_unittest.cc | 13 ++++
.../chrome_password_protection_service.cc | 69 +++++++++++++++++++---
.../chrome_password_protection_service.h | 14 +++++
.../chrome_password_protection_service_unittest.cc | 61 +++++++++++++++++++
.../core/browser/password_manager_client.h | 3 +
.../browser/password_reuse_detection_manager.cc | 5 ++
.../core/browser/stub_password_manager_client.cc | 2 +
.../core/browser/stub_password_manager_client.h | 1 +
components/safe_browsing/features.cc | 10 ++--
components/safe_browsing/features.h | 8 +++
.../password_protection_service.h | 4 ++
.../password_protection_service_unittest.cc | 3 +
14 files changed, 190 insertions(+), 13 deletions(-)

Upstream: git.chromium.org


  • Share