MD Settings: Site Details now allows users to override embargo

Desktop / Chromium - Patti [chromium.org] - 9 August 2017 04:09 EDT

Currently it is not possible to override embargo via Site Details, while it is possible in the Page Info bubble. This patch fixes that.

Manual test - With #enable-site-details on, navigate to https://permission.site. Click 'Notifications', wait for the prompt to appear, then press ESC to dismiss the prompt. Repeat until the prompt no longer appears. Open the Page Info bubble and verify 'Notifications' now has text underneath that reads 'Automatically blocked'. Click 'Site settings' (a button at the bottom of the Page Info bubble). Verify 'Automatically blocked' is now also in gray text underneath 'Notifications' in the Site Details page that opens up. Change the Notifications permission now to 'Ask (default)'. Switch back to the https://permission.site tab, refresh, and verify clicking the 'Notifications' button again shows a new prompt asking for Notifications permission.

Bug: 656758 Change-Id: I83251de4d90f191c5b1b7b2f23dd04966bc7ec60 Reviewed-on: https://chromium-review.googlesource.com/604768 Commit-Queue: Patti

8dee9cf MD Settings: Site Details now allows users to override embargo.
chrome/browser/ui/webui/settings/site_settings_handler.cc | 7 +++++++
1 file changed, 7 insertions(+)

Upstream: git.chromium.org


  • Share