Make --enable-benchmarking not affect metrics recording

Desktop / Chromium - asvitkine [chromium.org] - 14 June 2017 17:37 EDT

Previously, it would cause metrics to be in a special mode where metrics are recorded but never reported, which caused unbounded accumulation of data, such as user actions, in the UMA protos. This test-only mode didn't seem necessary, so removing it.

This also allowed a bunch of simplification, by removing a client interface and its implementation, moving a switch to the metrics component and removing some ios versions of the code.

BUG=730091

Review-Url: https://codereview.chromium.org/2933953002 Cr-Commit-Position: refs/heads/master@{#479511}

de445d9 Make --enable-benchmarking not affect metrics recording.
chrome/browser/metrics/chrome_metrics_services_manager_client.cc | 6 ------
chrome/browser/metrics/chrome_metrics_services_manager_client.h | 1 -
chrome/browser/metrics/metrics_service_browsertest.cc | 4 ++--
chrome/common/chrome_switches.cc | 7 -------
chrome/common/chrome_switches.h | 1 -
components/metrics/metrics_switches.cc | 7 +++++++
components/metrics/metrics_switches.h | 2 ++
components/metrics_services_manager/metrics_services_manager.cc | 5 ++++-
.../metrics_services_manager/metrics_services_manager_client.h | 3 ---
ios/chrome/browser/chrome_switches.cc | 7 -------
ios/chrome/browser/chrome_switches.h | 1 -
.../browser/metrics/ios_chrome_metrics_services_manager_client.h | 1 -
.../browser/metrics/ios_chrome_metrics_services_manager_client.mm | 5 -----
13 files changed, 15 insertions(+), 35 deletions(-)

Upstream: git.chromium.org


  • Share