network-config: Cleanup and add browsertests

Desktop / Chromium - Steven Bennetts [chromium.org] - 12 October 2017 04:24 EDT

This CL elimonate some redundant properties in network-config and adds some very basic browser tests.

It also cleans up some a11y issues found in the browsertest audit.

Bug: 380937 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibbdcf353244e6bbc3b45870b488c250d75800367 Reviewed-on: https://chromium-review.googlesource.com/709959

0bcdd42 network-config: Cleanup and add browsertests
.../resources/chromeos/internet_config_dialog.html | 3 +-
.../resources/chromeos/internet_config_dialog.js | 34 +++------
.../resources/chromeos/internet_detail_dialog.js | 2 +
.../settings/internet_page/internet_config.html | 5 +-
.../settings/internet_page/internet_config.js | 34 +++------
.../settings/internet_page/internet_detail_page.js | 2 +
chrome/test/data/webui/BUILD.gn | 1 +
chrome/test/data/webui/chromeos/cr_onc_strings.js | 81 ++++++++++++++++++++
.../fake_networking_private.js | 86 +++++++++++++++++++--
.../webui/chromeos/networking_private_constants.js | 88 ++++++++++++++++++++++
.../cr_components/cr_components_browsertest.js | 75 ++++++++++++++++++
.../webui/cr_components/network_config_test.js | 80 ++++++++++++++++++++
chrome/test/data/webui/fake_chrome_event.js | 8 +-
.../data/webui/settings/cr_settings_browsertest.js | 3 +-
.../data/webui/settings/internet_page_tests.js | 72 ++++++++++--------
.../chromeos/network/network_config.html | 2 +-
.../chromeos/network/network_config.js | 20 ++---
.../chromeos/network/network_config_input.html | 2 +-
.../chromeos/network/network_config_select.html | 2 +-
.../chromeos/network/network_config_select.js | 2 +-
20 files changed, 493 insertions(+), 109 deletions(-)

Upstream: git.chromium.org


  • Share