Re-land: Disable prerender by default

Desktop / Chromium - Egor Pasko [chromium.org] - 10 August 2017 15:05 EDT

Disable prerender to be on the safer side when the study expires.

On top of the original patch (http://crrev.com/491691) these changes are made:
- remove overrides in fieldtrial_testing_config.json to have the same prerender mode in tests as on the official bots
- SetUpOnMainThread() in prerender_browsertest.cc
- Avoid crashing when PRERENDER_DISABLED
- replace ASSERT_* with CHECK* in SetUpOnMainThread to get better diagnostics from problems with prerender configuration
- Enable prerendering for all of tests in prerender_unittest rather than selectively
- For offline_pages/ tests enable prerendering to the correct mode without requiring an instance of PrerenderManager - in the current state the PrerenderManager is always found, but it was not the case for PRERENDER_MODE_DISABLED,
- The CustomTabs tests force prerendering, but they still require an instance of PrerenderManager, which is not available with PRERENDER_MODE_DISABLED, added a comment about it.

Bug: 678332, 735153, 520275 Change-Id: I4761e0b99ebca615402ac1e71332c79bd3e4899f Reviewed-on: https://chromium-review.googlesource.com/603614 Commit-Queue: Egor Pasko

2ef465f Re-land: Disable prerender by default
.../activity_log/activity_log_unittest.cc | 4 +++
.../offline_pages/prerender_adapter_unittest.cc | 16 +++++++++-
.../autocomplete_action_predictor_unittest.cc | 8 +++++
chrome/browser/prerender/prerender_browsertest.cc | 4 +++
chrome/browser/prerender/prerender_field_trial.cc | 6 ++--
chrome/browser/prerender/prerender_manager.cc | 6 ++--
chrome/browser/prerender/prerender_manager.h | 11 ++++++-
chrome/browser/prerender/prerender_test_utils.cc | 26 +++++++++------
chrome/browser/prerender/prerender_unittest.cc | 37 +++++++++++-----------
.../search/instant_search_prerenderer_unittest.cc | 15 +++++++++
testing/variations/fieldtrial_testing_config.json | 24 --------------
11 files changed, 97 insertions(+), 60 deletions(-)

Upstream: git.chromium.org


  • Share