Reland of [ios showcase] Integrated TextBadgeView with Showcase

Desktop / Chromium - Helen Yang [google.com] - 13 July 2017 13:14 EDT

The CL [ios showcase] Integrated TextBadgeView with Showcase (patchset #4 id:80001 of https://codereview.chromium.org/2967113003/) broke ios_showcase_egtests suite for iPad. The revert can be found here: https://codereview.chromium.org/2978533002/.

This CL is a reland of the first, and fixes the egtest issue by ensuring that EarlGrey only selects sufficiently visible elements.

Bug: 740133 Change-Id: Ie30b78e85d965bd2ff48d27fef4eb7f824d56d98 Reviewed-on: https://chromium-review.googlesource.com/567129 Commit-Queue: Helen Yang

0a8ba8f Reland of [ios showcase] Integrated TextBadgeView with Showcase
ios/showcase/BUILD.gn | 2 ++
ios/showcase/core/showcase_model.mm | 5 ++++
ios/showcase/test/showcase_eg_utils.mm | 7 ++++-
ios/showcase/text_badge_view/BUILD.gn | 26 +++++++++++++++++++
.../sc_text_badge_view_controller.h | 13 ++++++++++
.../sc_text_badge_view_controller.mm | 24 +++++++++++++++++
.../text_badge_view/sc_text_badge_view_egtest.mm | 30 ++++++++++++++++++++++
7 files changed, 106 insertions(+), 1 deletion(-)

Upstream: git.chromium.org


  • Share