Reland of Add --headless flag to Windows (patchset #1 id:1 of https://codereview.chromium.org/2835603002/ )

Desktop / Chromium - dvallet [chromium.org] - 20 April 2017 21:09 EDT

Reason for revert: Re-land patch set, looks like it could've been a transient issue with Mac waterfall build, patching in updated upstream and investigating

Original issue's description: > Revert of Add --headless flag to Windows (patchset #28 id:540001 of https://codereview.chromium.org/2762593002/ ) > > Reason for revert: > > Findit(https://goo.gl/kROfz5) identified CL at revision 466176 as the > culprit for failures in the build cycles as shown on: > https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UzYzc0NWQ0YjM3YTY1OWFmYWEwMzU4YzdkZTdiOWJjODgxZGVjYjUM > > Original issue's description: > > Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=705916 > > > > Add --headless flag to Windows: > > > > Fix browser_tests not compiling properly on windows > > Fix headless/BUILD.gn by: > > - Changing headless_lib to a headless component, following steps in https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md and fixing the build for linux, since it now compiles as a shared_library when component build is true. > > - Adding neccesary HEADLESS_EXPORT (submitted in https://codereview.chromium.org/2775693003/) > > - Disabling breakpad in windows (will fix in a separate CL) > > > > > > BUG=686608 > > > > Review-Url: https://codereview.chromium.org/2762593002 > > Cr-Commit-Position: refs/heads/master@{#466176} > > Committed: https://chromium.googlesource.com/chromium/src/+/e3c745d4b37a659afaa0358c7de7b9bc881decb5 > > TBR=alexclarke@chromium.org,sky@chromium.org,skyostil@chromium.org,wfh@chromium.org,jzfeng@chromium.org,nick@chromium.org,dvallet@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686608 > > Review-Url: https://codereview.chromium.org/2835603002 > Cr-Commit-Position: refs/heads/master@{#466189} > Committed: https://chromium.googlesource.com/chromium/src/+/87a65c2fbb5db04ce025fadbfdfc7183003f6831

TBR=nick@chromium.org,tdanderson@google.com,jzfeng@chromium.org,fhorschig@google.com,sky@chromium.org,keishi@google.com,xlai@google.com,alexclarke@chromium.org,skyostil@chromium.org,wfh@chromium.org,tdanderson@chromium.org,findit-for-me@appspot.gserviceaccount.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686608

Review-Url: https://codereview.chromium.org/2832963002 Cr-Commit-Position: refs/heads/master@{#466206}

e0800c0 Reland of Add --headless flag to Windows (patchset #1 id:1 of https://codereview.chromium.org/2835603002/ )
chrome/BUILD.gn | 2 +
chrome/app/chrome_main.cc | 12 +-
headless/BUILD.gn | 146 +++++++++++++++++----
headless/DEPS | 2 +
headless/app/headless_example.cc | 15 +++
headless/app/headless_shell.cc | 30 ++++-
headless/app/headless_shell.h | 2 +-
headless/app/headless_shell_main.cc | 12 ++
headless/app/headless_shell_switches.cc | 3 +
headless/app/headless_shell_switches.h | 1 +
headless/lib/browser/DEPS | 1 -
headless/lib/browser/headless_browser_impl.cc | 14 +-
headless/lib/headless_browser_browsertest.cc | 14 +-
headless/lib/headless_content_main_delegate.cc | 17 ++-
headless/lib/headless_content_main_delegate.h | 8 +-
headless/public/headless_browser.cc | 20 +++
headless/public/headless_browser.h | 26 +++-
headless/public/headless_shell.h | 18 ++-
.../util/deterministic_http_protocol_handler.cc | 1 +
headless/public/util/generic_url_request_job.h | 7 +-
.../util/testing/generic_url_request_mocks.cc | 1 +
headless/test/headless_browser_test.cc | 2 +-
22 files changed, 280 insertions(+), 74 deletions(-)

Upstream: git.chromium.org


  • Share