Reland: Add net error pages to content shell

Desktop / Chromium - Alexander Semashko [yandex-team.ru] - 10 September 2017 18:43 EDT

Currently content shell shows a blank page on error. In content_browsertests the (unexpected, I guess) effect is that NavigateToURL returns true even when the page was not loaded. Also with error pages it will be easier to understand what's happening during debugging.

Patchset 1 corresponds to the previous CL https://crrev.com/c/650253, reverted in https://crrev.com/c/657077.

TBR=kolos@chromium.org,peter@chromium.org,primiano@chromium.org,jochen@chromium.org,mkwst@chromium.org,wjmaclean@chromium.org

Bug: 763252 Change-Id: Ie3b93ef7da557e2ebfb2fba32fabb0677b6c9359 Reviewed-on: https://chromium-review.googlesource.com/657183

043cf1d4 Reland: Add net error pages to content shell.
components/BUILD.gn | 1 +
content/browser/host_zoom_map_impl_browsertest.cc | 4 +--
content/browser/site_per_process_browsertest.cc | 12 +++----
.../browser/tracing/memory_tracing_browsertest.cc | 10 +++---
.../renderer/shell_content_renderer_client.cc | 38 +++++++++++++++++++++
.../shell/renderer/shell_content_renderer_client.h | 14 ++++++++
.../level2/html/HTMLIFrameElement11-expected.txt | 2 +-
.../fast/events/focusingUnloadedFrame-expected.txt | 3 +-
.../fast/events/onloadFrameCrash-expected.txt | 3 +-
.../recursive-before-unload-crash-expected.txt | 3 +-
.../tests/loading/bad-server-subframe-expected.txt | 1 +
.../xssAuditor/full-block-base-href-expected.txt | 5 +--
.../security/xssAuditor/full-block-base-href.html | 2 +-
.../full-block-get-from-iframe-expected.txt | 3 +-
.../full-block-iframe-javascript-url-expected.txt | 5 +--
.../full-block-iframe-javascript-url.html | 2 +-
.../full-block-javascript-link-expected.txt | 5 +--
.../xssAuditor/full-block-javascript-link.html | 2 +-
.../full-block-link-onclick-expected.txt | 5 +--
.../xssAuditor/full-block-link-onclick.html | 2 +-
.../xssAuditor/full-block-object-tag-expected.txt | 5 +--
.../security/xssAuditor/full-block-object-tag.html | 2 +-
.../full-block-post-from-iframe-expected.txt | 3 +-
...full-block-script-tag-cross-domain-expected.txt | 5 +--
.../full-block-script-tag-cross-domain.html | 4 +--
.../xssAuditor/full-block-script-tag-expected.txt | 5 +--
.../full-block-script-tag-with-source-expected.txt | 5 +--
.../full-block-script-tag-with-source.html | 2 +-
.../security/xssAuditor/full-block-script-tag.html | 2 +-
.../malformed-xss-protection-header-1-expected.txt | 3 +-
.../malformed-xss-protection-header-2-expected.txt | 3 +-
.../malformed-xss-protection-header-3-expected.txt | 3 +-
.../malformed-xss-protection-header-4-expected.txt | 3 +-
.../malformed-xss-protection-header-5-expected.txt | 3 +-
.../malformed-xss-protection-header-6-expected.txt | 3 +-
.../malformed-xss-protection-header-7-expected.txt | 3 +-
.../malformed-xss-protection-header-8-expected.txt | 3 +-
.../malformed-xss-protection-header-9-expected.txt | 3 +-
.../xss-protection-parsing-01-expected.txt | 3 +-
.../xss-protection-parsing-03-expected.txt | 3 +-
.../xss-protection-parsing-04-expected.txt | 3 +-
.../tables/mozilla/bugs/bug137388-1-expected.png | Bin 0 -> 9448 bytes
.../tables/mozilla/bugs/bug137388-2-expected.png | Bin 25591 -> 32145 bytes
.../tables/mozilla/bugs/bug137388-2-expected.png | Bin 25607 -> 26879 bytes
.../tables/mozilla/bugs/bug137388-1-expected.png | Bin 0 -> 4214 bytes
.../tables/mozilla/bugs/bug137388-2-expected.png | Bin 25577 -> 26845 bytes
.../tables/mozilla/bugs/bug137388-1-expected.png | Bin 0 -> 4255 bytes
.../tables/mozilla/bugs/bug137388-2-expected.png | Bin 25589 -> 26897 bytes
.../tables/mozilla/bugs/bug137388-1-expected.png | Bin 2916 -> 0 bytes
49 files changed, 135 insertions(+), 56 deletions(-)

Upstream: git.chromium.org


  • Share