Reland: Password settings on iOS: use Title Case

Desktop / Chromium - Vaclav Brozek [chromium.org] - 12 July 2017 17:43 EDT

The original CL https://chromium-review.googlesource.com/567930 was reverted because EG tests were not synchronised with the string change. The reverted CL is patch set 1 here. The fix consists of updating the tests, those are all subsequent patch sets here.

Original description:

Most of setting headers in the passwords seciton on iOS already use Title Case, except for the headers of the saved and blacklisted lists of passwords.

This CL fixes that by creating new strings for iOS settings inside ios/chrome/app/strings/ios_strings.grd. Previously the code used shared strings from the password_manager component (components/password_manager_strings.grdp). That string was also used by the old (non-MD) desktop settings, which have already been deprecated. The MD settings on desktop use the Title Case as iOS should as well, but the MD settings strings are consistently saved in chrome/app/settings_strings.grdp, where they cannot be shared with iOS.

The CL creates the new string instead of sharing the one from MD settings, because sharing has no benefit (on no build both strings are included, so no storage spared) and has the drawback of binding the style of both strings forever together.

The CL does not remove the component string yet. The old desktop settings code is still in the codebase, and the shared string (used only by the old settings) should be deleted once those old settings are deleted.


Bug: 740952 Change-Id: I1b166a4961235fdaa5a122795cc016d9b5438612 Reviewed-on: https://chromium-review.googlesource.com/568497 Commit-Queue: Vaclav Brozek Commit-Queue: Louis Romero

31b2b6f Reland: Password settings on iOS: use Title Case
ios/chrome/app/strings/ios_strings.grd | 6 ++++++
ios/chrome/browser/ui/settings/passwords_settings_egtest.mm | 2 +-
.../ui/settings/save_passwords_collection_view_controller.mm | 5 ++---
ios/chrome/browser/ui/settings/settings_egtest.mm | 6 +++---
4 files changed, 12 insertions(+), 7 deletions(-)

Upstream: git.chromium.org


  • Share