Remove ListValue::Append(raw ptr) on Win

Desktop / Chromium - vabr [chromium.org] - 15 April 2017 06:07 EDT

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be used instead. This CL achieves that on Win, which is the last platform to still use the raw-pointer Append.

The CL also changes some related calls to DictionaryValue::Set to take a unique_ptr instead of a raw one.

BUG=581865 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2809933003 Cr-Commit-Position: refs/heads/master@{#464866}

7cc8da7 Remove ListValue::Append(raw ptr) on Win
base/values.cc | 7 -------
base/values.h | 4 ----
chrome/browser/win/enumerate_modules_model.cc | 6 ++++--
.../policy/core/common/policy_loader_win_unittest.cc | 14 ++++++++------
components/wifi/wifi_service_win.cc | 9 ++++++---
content/browser/tracing/etw_tracing_agent_win.cc | 9 ++++++---
content/common/font_list_win.cc | 10 ++++++----
remoting/host/pairing_registry_delegate_win.cc | 6 +++---
8 files changed, 33 insertions(+), 32 deletions(-)

Upstream: git.chromium.org


  • Share