Remove MockWebRTCPeerConnectionHandler

Desktop / Chromium - Harald Alvestrand [chromium.org] - 11 October 2017 02:50 EDT

This mock appears superfluous, and maintaining it is a burden. Removing the mock uncovered several interesting errors where WPT tests exposed real bugs in our code, which had been hidden by the mock (which usually caused the tests to fail before they got to the real bugs).

See also: 771540

Bug: 706359 Change-Id: I1597f1261db741dfa1b6cd1804aa1c9c9ddfe9e3 Reviewed-on: https://chromium-review.googlesource.com/697806

642adbe Remove MockWebRTCPeerConnectionHandler
content/public/renderer/content_renderer_client.cc | 6 -
content/public/renderer/content_renderer_client.h | 8 -
content/renderer/renderer_blink_platform_impl.cc | 6 -
.../layout_test_content_renderer_client.cc | 12 -
.../layout_test_content_renderer_client.h | 3 -
content/shell/test_runner/BUILD.gn | 6 -
.../mock_webrtc_data_channel_handler.cc | 110 ---
.../test_runner/mock_webrtc_data_channel_handler.h | 62 --
.../test_runner/mock_webrtc_dtmf_sender_handler.cc | 63 --
.../test_runner/mock_webrtc_dtmf_sender_handler.h | 49 --
.../mock_webrtc_peer_connection_handler.cc | 796 ---------------------
.../mock_webrtc_peer_connection_handler.h | 119 ---
content/shell/test_runner/web_frame_test_proxy.h | 6 -
content/shell/test_runner/web_test_interfaces.cc | 8 -
third_party/WebKit/LayoutTests/TestExpectations | 24 +-
.../wpt/webrtc/RTCCertificate-expected.txt | 6 +-
.../RTCConfiguration-bundlePolicy-expected.txt | 4 +-
.../RTCConfiguration-iceServers-expected.txt | 12 +-
.../RTCConfiguration-rtcpMuxPolicy-expected.txt | 6 +-
.../RTCDataChannel-bufferedAmount-expected.txt | 7 +
.../wpt/webrtc/RTCDataChannel-id-expected.txt | 5 -
.../wpt/webrtc/RTCDataChannel-send-expected.txt | 13 +
...tlsTransport-getRemoteCertificates-expected.txt | 4 +
.../wpt/webrtc/RTCIceTransport-expected.txt | 5 +
.../RTCPeerConnection-addIceCandidate-expected.txt | 46 +-
...Connection-canTrickleIceCandidates-expected.txt | 4 +-
.../RTCPeerConnection-constructor-expected.txt | 4 +-
.../RTCPeerConnection-createAnswer-expected.txt | 6 +-
...TCPeerConnection-createDataChannel-expected.txt | 4 +-
.../RTCPeerConnection-createOffer-expected.txt | 11 +
...TCPeerConnection-iceGatheringState-expected.txt | 1 -
.../wpt/webrtc/RTCPeerConnection-idl-expected.txt | 6 +-
.../RTCPeerConnection-ondatachannel-expected.txt | 6 +
...PeerConnection-onnegotiationneeded-expected.txt | 10 +
.../webrtc/RTCPeerConnection-ontrack-expected.txt | 4 +-
...nection-setLocalDescription-answer-expected.txt | 9 +
...PeerConnection-setLocalDescription-expected.txt | 7 +
...nnection-setLocalDescription-offer-expected.txt | 10 +
...ction-setLocalDescription-pranswer-expected.txt | 10 +
...ction-setLocalDescription-rollback-expected.txt | 0
...ection-setRemoteDescription-answer-expected.txt | 7 +
...eerConnection-setRemoteDescription-expected.txt | 7 -
...nection-setRemoteDescription-offer-expected.txt | 9 +
...tion-setRemoteDescription-pranswer-expected.txt | 10 +
...tion-setRemoteDescription-rollback-expected.txt | 0
.../webrtc/datachannel-emptystring-expected.txt | 2 +-
.../external/wpt/webrtc/getstats-expected.txt | 4 -
.../external/wpt/webrtc/interfaces-expected.txt | 2 +-
.../external/wpt/webrtc/no-media-call-expected.txt | 4 -
.../external/wpt/webrtc/promises-call-expected.txt | 4 -
.../RTCPeerConnection-createAnswer-promise.html | 51 --
.../RTCPeerConnection-createAnswer.html | 64 --
...PeerConnection-createOffer-promise-expected.txt | 15 -
.../RTCPeerConnection-createOffer-promise.html | 47 +-
.../RTCPeerConnection-createOffer.html | 122 ----
.../RTCPeerConnection-datachannel-expected.txt | 45 --
.../RTCPeerConnection-dtmf-expected.txt | 23 -
.../RTCPeerConnection-getReceivers.html | 322 ---------
.../RTCPeerConnection-getStats-promise.html | 80 ---
.../RTCPeerConnection-ice-promise-expected.txt | 17 -
.../RTCPeerConnection-lifetime-expected.txt | 14 -
...RTCPeerConnection-localDescription-promise.html | 69 --
.../RTCPeerConnection-localDescription.html | 84 ---
...TCPeerConnection-remoteDescription-promise.html | 69 --
.../RTCPeerConnection-remoteDescription.html | 84 ---
.../RTCPeerConnection-stats-expected.txt | 8 +-
.../peerconnection/RTCPeerConnection-stats.html | 9 +-
.../RTCPeerConnection-statsSelector-expected.txt | 1 -
.../RTCPeerConnection-statsSelector.html | 3 +-
69 files changed, 191 insertions(+), 2463 deletions(-)

Upstream: git.chromium.org


  • Share